4 Commits
Author SHA1 Message Date
dsql 849a6f51e7 chore: bump to 1.1.1
Signed-off-by: disqualifier <dev@disqualifier.me>
2026-10-16 04:36:04 -04:00
dsql 982651af7a perf: resolve the log channel from the guild cache before fetch_channel
T3-19: _get_channel did an HTTP fetch_channel (GET /channels/{id}) on every
guild-routed log line, in both the self.channel and settings paths. try
guild.get_channel first; fetch only on a cache miss. same channel, same
ValueError normalization.

Signed-off-by: disqualifier <dev@disqualifier.me>
2026-10-16 04:36:00 -04:00
dsql 0e0646a5d6 chore: bump to 1.1.0 (logging-discipline audit)
Signed-off-by: disqualifier <dev@disqualifier.me>
2026-08-10 23:00:50 -04:00
dsql 270d7df9ae fix: discord send failure logs WARNING, not ERROR (D4)
_send mirrors the record to the stdlib sink BEFORE attempting the discord send, so a
swallowed send failure is recovered cleanly - the log survives, only the channel mirror
was lost. that is a WARNING (recovered), not an ERROR. demote from _log.exception (ERROR +
traceback) to _log.warning with the reason folded in lazily; the traceback belonged on a
terminal/unhandled path, and this one recovers via the guaranteed stdlib record.

Signed-off-by: disqualifier <dev@disqualifier.me>
2026-08-09 02:14:11 -04:00
3 changed files with 15 additions and 9 deletions

No files matched your search

+3 -3
View File
@@ -10,18 +10,18 @@ live from `bot.settings` so it can change at runtime via a command.
`requirements.txt`:
```
dpy_logger @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_logger.git@v1.0.0
dpy_logger @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_logger.git@v1.1.1
```
Direct:
```bash
pip install "dpy_logger @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_logger.git@v1.0.0"
pip install "dpy_logger @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_logger.git@v1.1.1"
```
Requires `discord.py` (pulled transitively).
Drop the `@v1.0.0` suffix from the line above to install the latest unpinned.
Drop the `@v1.1.1` suffix from the line above to install the latest unpinned.
## Usage
+1 -1
View File
@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
[project]
name = "dpy_logger"
version = "1.0.0"
version = "1.1.1"
description = "Leveled Discord channel logger for discord.py — config-free, injectable, installable."
requires-python = ">=3.10"
dependencies = [
+11 -5
View File
@@ -130,7 +130,10 @@ class DPYLogger:
raise ValueError("[dpy_logger] no guild available for logging")
async def _get_channel(self, guild, override=False):
"""resolve the log channel, preferring self.channel when the guild matches"""
"""resolve the log channel, preferring self.channel when the guild matches
the guild's channel cache is tried first; fetch_channel (an HTTP GET) only runs on a
cache miss (e.g. a fetched, uncached guild)"""
if not guild:
raise ValueError("[dpy_logger] cannot resolve channel without a guild")
@@ -141,7 +144,7 @@ class DPYLogger:
# fetch_channel raises NotFound/Forbidden/HTTPException/InvalidData (a
# ClientException, not an HTTPException); normalize all to ValueError
try:
channel = await guild.fetch_channel(self.channel)
channel = guild.get_channel(self.channel) or await guild.fetch_channel(self.channel)
except (discord.HTTPException, discord.ClientException) as error:
raise ValueError(f"[dpy_logger] could not fetch channel {self.channel}: {error}") from error
if not isinstance(channel, discord.TextChannel):
@@ -153,7 +156,7 @@ class DPYLogger:
except KeyError as error:
raise ValueError(f"[dpy_logger] no log channel configured for guild {guild.id}") from error
try:
channel = await guild.fetch_channel(channel_id)
channel = guild.get_channel(channel_id) or await guild.fetch_channel(channel_id)
except (discord.HTTPException, discord.ClientException) as error:
raise ValueError(f"[dpy_logger] could not fetch channel {channel_id}: {error}") from error
if not isinstance(channel, discord.TextChannel):
@@ -213,8 +216,11 @@ class DPYLogger:
content=content,
embed=self.build_embed(level, action, actor, log_msg),
)
except Exception:
_log.exception(f"[dpy_logger] failed to send {level} log: {log_msg}")
except Exception as exc:
# WARNING, not ERROR: the record was already mirrored to the stdlib sink BEFORE the
# send (see _emit_stdlib above), so a swallowed discord-send failure is recovered
# cleanly - the log survives, only the channel mirror was lost. lazy interpolation.
_log.warning("[dpy_logger] failed to send %s log: %s (%s)", level, log_msg, exc)
return None
async def debug(self, log, action=None, actor=None, guild=None, log_to_file=None):