pl_devs/monitor-shared-utils
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
143 Commits 2 Branches 0 Tags
7d514a54016be2120b6165cc38611e74545df6f6
Commit Graph
143 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
dsql 7d514a5401 Merge pull request 'calculate_priority: resolve non-finite prices to 0 instead of crashing the monitor' (#25) from development into main 2026-10-08 22:48:57 +00:00
dsqlandClaude Code Opus 5.5 f51aed2c9f calculate_priority: resolve non-finite prices to 0 instead of crashing the monitor 
tpv-academysports died on 2026-10-08 06:27 UTC and stayed down: six
identical crashes in 8 minutes (each ~2 min after start), then docker's
on-failure:5 gave up. Every one was

    database.py, in calculate_priority
        percentage = int(((original_price - current_price) / original_price) * 100)
    OverflowError: cannot convert float infinity to integer

A monitor builds prices with float() on the retailer's raw field, and
float() accepts "Infinity" / "1e999", so a non-finite price reaches here.
The `not original_price` guard catches None and 0, not inf or nan, and the
exception escapes add_products_to_database -> run_monitor_cycle and kills
the whole process -- one bad product takes the monitor down, and it
crashes again on every restart while that product is listed. Every
monitor that uses this lib has the same exposure.

calculate_priority now returns 0 (the existing "broken prices" bucket)
for a non-finite current/original price, and for a finite pair whose
ratio still overflows (a subnormal original price). Tests cover both;
they fail on the old code (OverflowError, plus ValueError for nan) and
pass now (tests/test_alert_priority.py: 10 passed).

Not changed: the monitor-side float() parsing, which could reject these
prices before they are stored -- worth a look by the monitor owners.

Co-Authored-By: Claude Code Opus 5.5 (ansible-ops, auto-repair) <noreply@anthropic.com>
Signed-off-by: disqualifier <dev@disqualifier.me>
 2026-10-08 18:46:59 -04:00
TPV bd5df3a4c2 Merge pull request 'small cleanup of comments/added optional impersonate into run_bounded_cycle for monitors like bhphoto that need different clients than what we support/dont need to rotate' (#24) from development into main 
Reviewed-on: #24
 2026-09-30 01:56:40 +00:00
TPV 6720592685 small cleanup of comments/added optional impersonate into run_bounded_cycle for monitors like bhphoto that need different clients than what we support/dont need to rotate 2026-09-29 18:55:52 -07:00
TPV 1b3f860ff3 Merge pull request 'updated tls profiles' (#23) from development into main 
Reviewed-on: #23
 2026-09-27 04:11:53 +00:00
TPV 4563cdf920 updated tls profiles 2026-09-26 21:11:37 -07:00
TPV 7032f5b9d6 Merge pull request 'added get_response_json function to return json from aioweb' (#22) from development into main 
Reviewed-on: #22
 2026-09-26 03:00:57 +00:00
TPV b9fbb64364 added get_response_json function to return json from aioweb 2026-09-25 20:00:19 -07:00
TPV ae637a134f rename monitor_name parameters to monitor 
Applies to setup_monitor_logging, init_monitor, setup_config, get_config,
add_products_to_database and build_alert. Breaking for callers passing
monitor_name by keyword; every monitor repo is updated alongside.
 2026-09-25 19:02:09 -07:00
TPV 4729a62ae2 Merge pull request 'renamed monitor_name to monitor' (#21) from development into main 
Reviewed-on: #21
 2026-09-26 00:29:32 +00:00
TPV 401258f52a renamed monitor_name to monitor 2026-09-25 17:29:08 -07:00
TPV 2bf2c613a9 Merge pull request 'added asins to build_product_details' (#20) from development into main 
Reviewed-on: #20
 2026-09-10 13:39:02 +00:00
TPV 9a34ae5ca6 added asins to build_product_details 2026-09-10 06:38:44 -07:00
TPV 0fceafb364 Merge pull request 'added price drops to alerts/fixed race condition where late claimed docs got their tags wiped and sent to the api without tags' (#19) from development into main 
Reviewed-on: #19
 2026-09-09 16:52:30 +00:00
TPV 0275f94500 added price drops to alerts/fixed race condition where late claimed docs got their tags wiped and sent to the api without tags 2026-09-09 09:52:15 -07:00
TPV 69484c5ae0 Merge pull request 'added asins for woot listings' (#18) from development into main 
Reviewed-on: #18
 2026-09-09 03:15:06 +00:00
TPV 03cc3a35cb added asins for woot listings 2026-09-08 20:14:49 -07:00
TPV c9545ec9d8 Merge pull request 'updated the db name for dsql mongo' (#17) from development into main 
Reviewed-on: #17
 2026-08-31 00:59:22 +00:00
TPV 93013c5d55 updated the db name for dsql mongo 2026-08-30 17:59:05 -07:00
TPV 7f30a8a5cc Merge pull request 'updated the mongo_url to dsqls new url/small type hint fixes' (#16) from development into main 
Reviewed-on: #16
 2026-08-31 00:55:21 +00:00
TPV 39a6c40154 updated the mongo_url to dsqls new url/small type hint fixes 2026-08-30 17:54:40 -07:00
TPV 87d751cd82 Merge pull request 'added optional mongo client for already configured monitors' (#15) from development into main 
Reviewed-on: #15
 2026-08-21 15:22:35 +00:00
TPV 1218ba0b3c added optional mongo client for already configured monitors 2026-08-21 08:21:57 -07:00
TPV 2a5d649f90 Merge pull request 'added optional mongo url' (#14) from development into main 
Reviewed-on: #14
 2026-08-21 14:52:50 +00:00
TPV b599d34e1e added optional mongo url 2026-08-21 07:52:21 -07:00
TPV 04ce7b50f3 Merge pull request 'bug fix to avoid swallowing exceptions/failed pages inside fetch_all_pages/small refactor/added new listings' (#13) from development into main 
Reviewed-on: #13
 2026-08-13 20:23:00 +00:00
TPV b071ac35bf bug fix to avoid swallowing exceptions/failed pages inside fetch_all_pages/small refactor 2026-08-12 17:45:59 -07:00
TPV cc46e3d409 Merge pull request 'removed retry_failed_pages from docstrings' (#12) from development into main 
Reviewed-on: #12
 2026-08-09 02:00:14 +00:00
TPV 321546f9b9 removed retry_failed_pages from docstrings 2026-08-08 18:59:52 -07:00
TPV 5db82e3a59 Merge pull request 'removed failed page retrying' (#11) from development into main 
Reviewed-on: #11
 2026-08-08 20:51:09 +00:00
TPV 0b462aef06 removed failed page retrying 2026-08-08 13:49:35 -07:00
TPV 95af8a37e1 Merge pull request 'added no msrp prirority so they don't starve in queue' (#10) from development into main 
Reviewed-on: #10
 2026-08-04 20:54:19 +00:00
TPV dee090edaf added no msrp prirority so they don't starve in queue 2026-08-04 13:53:32 -07:00
TPV 2ede6c77c7 Merge pull request 'use .get for has_msrp' (#9) from development into main 
Reviewed-on: #9
 2026-08-04 18:49:45 +00:00
TPV 6c309b1e62 use .get for has_msrp 2026-08-04 11:49:19 -07:00
TPV b34db200cc Merge pull request 'small typo fix' (#8) from development into main 
Reviewed-on: #8
 2026-08-04 17:07:56 +00:00
TPV 1f5224a92c small typo fix 2026-08-04 10:07:31 -07:00
TPV 7c420059ee Merge pull request 'added has_msrp for no msrp based products(new lists)' (#7) from development into main 
Reviewed-on: #7
 2026-08-04 17:05:36 +00:00
TPV 61c4887c38 added has_msrp for no msrp based products(new lists) 2026-08-04 10:04:32 -07:00
TPV 2e6e7ebc69 added passing headers 2026-07-30 14:29:58 -07:00
TPV 8903be2685 abstracted out bounded cycles 2026-07-30 14:13:26 -07:00
TPV aa6ed4cb06 added pagination fan out pagination abstraction 2026-07-30 11:52:36 -07:00
TPV 3f823b3a6e added price history to build_product_details/models 2026-07-28 11:29:15 -07:00
TPV 3573551957 removed past_prices 2026-07-28 10:38:33 -07:00
TPV 8a1c1893b7 added bounded close session for curl_cffi/past_prices to pricing model 2026-07-28 09:15:38 -07:00
TPV c29032a765 cleanup 2026-07-27 12:02:56 -07:00
TPV 1e53904cc6 added max_clients arg to get_default_session/cycle timeout seconds 2026-07-27 12:02:41 -07:00
TPV 99e68b1fa9 added first_error for asyncio task groups 2026-07-27 10:27:57 -07:00
TPV b6cd692258 added first_error for asyncio task groups 2026-07-27 10:23:07 -07:00
TPV 763f40988f added cycle timeout seconds 2026-07-27 08:49:59 -07:00