rethink-public/log_setup
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: drop _file_handler's unused name parameter

Browse Source 
leftover from the v0.5.0 history-namespace split - every path inside
_file_handler already uses live_path/history_stem/log_dir, never name. the
docstring still explained it as "the LIVE stem" though nothing read it.

Signed-off-by: disqualifier <dev@disqualifier.me>
This commit is contained in:
dsql
2026-07-06 00:15:10 -04:00
parent ca9bf4520b
commit f8d3322591
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/log_setup/setup.py
+4 -4
View File
@@ -144,14 +144,14 @@ def _history_stem() -> str:
def _file_handler( def _file_handler(
name: str, history_stem: str, live_path: str, log_dir: str, rotate: Optional[str], history_stem: str, live_path: str, log_dir: str, rotate: Optional[str],
backup_count: int, max_bytes: int, compress: bool, backup_count: int, max_bytes: int, compress: bool,
keep_uncompressed: Optional[int], keep_compressed: Optional[int], warnings: list, keep_uncompressed: Optional[int], keep_compressed: Optional[int], warnings: list,
) -> logging.Handler: ) -> logging.Handler:
"""build the configured file handler with custom rolling into log_dir """build the configured file handler with custom rolling into log_dir
`name` is the LIVE stem; `history_stem` is the PROJECT stem that rolled/historic `history_stem` is the PROJECT stem that rolled/historic files are named off,
files are named off, decoupled from the live file's own name. decoupled from the live file's own name (`live_path`).
""" """
tiered = keep_uncompressed is not None or keep_compressed is not None tiered = keep_uncompressed is not None or keep_compressed is not None
if rotate == "size": if rotate == "size":
@@ -285,7 +285,7 @@ def setup_logging(
if file_ok: if file_ok:
try: try:
fh = _file_handler( fh = _file_handler(
stem, history_stem, live_path, log_dir, rotate, backup_count, max_bytes, compress, history_stem, live_path, log_dir, rotate, backup_count, max_bytes, compress,
keep_uncompressed, keep_compressed, warnings, keep_uncompressed, keep_compressed, warnings,
) )
fh.setFormatter(formatter) fh.setFormatter(formatter)