rethink-public/dpy_paginator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: drop exc_info on the best-effort cleanup warnings

Browse Source 
cache_button refresh and on_timeout delete are best-effort cleanup that swallow the
HTTPException and recover; both logged at WARNING with exc_info=True, dumping a full
traceback on a handled-and-recovered path. exc_info belongs on terminal/unhandled paths -
drop it and fold the exception reason in with %s so the diagnostic is kept without the
traceback noise.

Signed-off-by: disqualifier <dev@disqualifier.me>
This commit is contained in:
dsql
2026-08-09 02:13:12 -04:00
parent 438a15813f
commit 5095953257
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/dpy_paginator/dpy_paginator.py
+8 -5
View File
@@ -385,8 +385,10 @@ class DPYPaginator(Generic[PageT_co], discord.ui.View):
await self.message.edit(**kwargs) await self.message.edit(**kwargs)
except (discord.NotFound, discord.Forbidden): except (discord.NotFound, discord.Forbidden):
pass pass
except discord.HTTPException: except discord.HTTPException as exc:
log.warning("paginator cache_button: failed to refresh message", exc_info=True) # swallowed best-effort cleanup that recovers - no traceback (exc_info belongs
# on terminal/unhandled paths); the reason is folded in for diagnosis.
log.warning("paginator cache_button: failed to refresh message: %s", exc)
@discord.ui.button(style=discord.ButtonStyle.blurple) @discord.ui.button(style=discord.ButtonStyle.blurple)
async def next_page(self, interaction: Interaction, _: discord.ui.Button[Self]) -> None: async def next_page(self, interaction: Interaction, _: discord.ui.Button[Self]) -> None:
@@ -464,9 +466,10 @@ class DPYPaginator(Generic[PageT_co], discord.ui.View):
await self.message.delete() await self.message.delete()
except (discord.NotFound, discord.Forbidden): except (discord.NotFound, discord.Forbidden):
pass pass
except discord.HTTPException: except discord.HTTPException as exc:
# best-effort cleanup task; log rather than raise into an unretrieved task # best-effort cleanup task; log rather than raise into an unretrieved task. no
log.warning("paginator on_timeout: failed to delete message", exc_info=True) # traceback (exc_info belongs on terminal/unhandled paths) - fold the reason in.
log.warning("paginator on_timeout: failed to delete message: %s", exc)
# back-compat alias: the class was originally named ButtonPaginator; DPYPaginator is # back-compat alias: the class was originally named ButtonPaginator; DPYPaginator is