fix: cache=[] disables the button (not raises); nav row stays suppressed on re-render (v0.1.4)
M-3: the cache-length guard used 'cache is not None', so cache=[] ([] is not None) hit the length check and raised at construction — contradicting README/CLAUDE that say a falsy cache disables the button (matching the render path 'if self.cache:'). guard now uses 'if cache' so [] and None both disable; a non-empty too-short cache still raises. dpy_paginator-F2: update_buttons() now ANDs nav with max_pages>=2, so a single-page re-render (update_page -> _build_render_kwargs, default nav=True) no longer resurrects the nav row over the page's custom buttons. start()'s single-page branch simplified accordingly. verified by execution with real discord.py: []-disables and None-disables both construct, real cache renders, too-short still raises; single-page re-render keeps nav suppressed + custom button, multi-page control still shows nav. Signed-off-by: disqualifier <dev@disqualifier.me>
This commit is contained in:
@@ -9,18 +9,18 @@ buttons) behind previous / jump / next navigation, with an optional cache button
|
||||
`requirements.txt`:
|
||||
|
||||
```
|
||||
dpy_paginator @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_paginator.git@v0.1.3
|
||||
dpy_paginator @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_paginator.git@v0.1.4
|
||||
```
|
||||
|
||||
Direct:
|
||||
|
||||
```bash
|
||||
pip install "dpy_paginator @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_paginator.git@v0.1.3"
|
||||
pip install "dpy_paginator @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_paginator.git@v0.1.4"
|
||||
```
|
||||
|
||||
Requires `discord.py` (pulled transitively).
|
||||
|
||||
Drop the `@v0.1.3` suffix from the line above to install the latest unpinned.
|
||||
Drop the `@v0.1.4` suffix from the line above to install the latest unpinned.
|
||||
|
||||
## Basic usage
|
||||
|
||||
|
||||
Reference in New Issue
Block a user