fix: normalize construction-channel fetch errors; reject wrong-type channel objects at setup (dpylogger-7/8)

initialize() previously let a bad construction channel id leak raw
discord.errors.NotFound/Forbidden/HTTPException past the documented
ValueError-only setup contract, and let an already-resolved non-TextChannel
object (Thread/VoiceChannel/ForumChannel) pass silently, later misrouting or
blackholing every send. Wrap the construction-channel fetch in the same
try/except as the settings path and type-check the resolved-object channel
path, mirroring the existing int-path guard.

Widened the normalization tuple to also catch discord.ClientException
(covers InvalidData), fixing dpylogger-9 opportunistically since it's the
same pattern.

Bump to v0.1.5.

Signed-off-by: disqualifier <dev@disqualifier.me>

README.md

@@ -10,18 +10,18 @@ live from `bot.settings` so it can change at runtime via a command.
 `requirements.txt`:
 
 ```
-dpy_logger @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_logger.git@v0.1.2
+dpy_logger @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_logger.git@v0.1.5
 ```
 
 Direct:
 
 ```bash
-pip install "dpy_logger @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_logger.git@v0.1.2"
+pip install "dpy_logger @ git+ssh://git@git.rethinkstudios.io/rethink-public/dpy_logger.git@v0.1.5"
 ```
 
 Requires `discord.py` (pulled transitively).
 
-Drop the `@v0.1.2` suffix from the line above to install the latest unpinned.
+Drop the `@v0.1.4` suffix from the line above to install the latest unpinned.
 
 ## Usage
 
@@ -72,13 +72,15 @@ await bot.log.debug("noisy", log_to_file=False)   # -> Discord only
 
 ## Errors
 
-Resolution failures (unresolvable guild/channel, bad config, a non-text channel) raise
+Resolution failures (unresolvable guild/channel, bad config, a non-text channel — whether
-`ValueError` from `initialize()` — a misconfigured logger should fail loudly at setup.
+passed as an id or as an already-resolved object) raise `ValueError` from `initialize()` —
-Underlying `discord` exceptions (`NotFound` / `Forbidden` / `HTTPException`) from
+a misconfigured logger should fail loudly at setup. Underlying `discord` exceptions
-`fetch_guild`/`fetch_channel` are normalized to that `ValueError` so callers see one
+(`NotFound` / `Forbidden` / `HTTPException` / `InvalidData` and other `ClientException`
-error type. On a **per-call** send, neither resolution nor send failures propagate: they
+subclasses) from `fetch_guild`/`fetch_channel` are normalized to that `ValueError` on every
-fall back to the stdlib logger so a transient Discord failure (or a per-call `guild=`
+resolution path (construction channel, per-guild settings lookup) so callers see one error
-that doesn't resolve) never breaks the caller's command.
+type. On a **per-call** send, neither resolution nor send failures propagate: they fall
+back to the stdlib logger so a transient Discord failure (or a per-call `guild=` that
+doesn't resolve) never breaks the caller's command.
 
 ## Construction contract
 

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "dpy_logger"
-version = "0.1.2"
+version = "0.1.5"
 description = "Leveled Discord channel logger for discord.py — config-free, injectable, installable."
 requires-python = ">=3.10"
 dependencies = [

src/dpy_logger/dpy_logger.py

@@ -40,11 +40,15 @@ happens before the discord send, so the record survives even if discord fails.
 extending: this base has no feed/announcement method by design. a project
 that wants one subclasses DPYLogger and adds it, reusing _resolve.
 
-errors: resolution failures (unresolvable guild/channel, bad config) raise
+errors: resolution failures (unresolvable guild/channel, bad config, a
+non-text channel passed as either an id or an already-resolved object) raise
 ValueError from `initialize()` — a misconfigured logger should fail loudly at
-setup. on a per-call send, resolution AND send failures do NOT propagate: they
+setup. underlying discord exceptions (NotFound/Forbidden/HTTPException/
-fall back to the stdlib logger so a transient discord failure (or a per-call
+InvalidData and other ClientException subclasses) are normalized to that
-`guild=` that doesn't resolve) never breaks the caller's command.
+ValueError on every resolution path. on a per-call send, resolution AND send
+failures do NOT propagate: they fall back to the stdlib logger so a transient
+discord failure (or a per-call `guild=` that doesn't resolve) never breaks the
+caller's command.
 """
 
 import logging
@@ -111,6 +115,20 @@ class DPYLogger:
             if not self.guild:
                 raise ValueError(f"[dpy_logger] cannot resolve channel {self.channel} without a guild")
             self.channel = await self._get_channel(self.guild)
+        # a channel object passed with no guild (e.g. bot.get_channel(id)) would pass
+        # setup silently but then fail every send at _get_guild(None) — swallowed, so
+        # nothing reaches discord. derive the guild from the channel it already carries,
+        # or fail loud at setup (matching the int-channel guard above) rather than later.
+        if self.guild is None and isinstance(self.channel, discord.TextChannel):
+            self.guild = self.channel.guild
+        if self.guild is None and self.channel is not None:
+            raise ValueError("[dpy_logger] channel provided without a resolvable guild")
+        # a resolved wrong-type object (Thread/VoiceChannel/ForumChannel) would also pass
+        # setup silently — _get_channel only recognizes TextChannel/int, so anything else
+        # falls through to the bot.settings lookup at send time and misroutes or blackholes
+        # the sink. fail loud here, mirroring the int-path check in _get_channel.
+        if self.channel is not None and not isinstance(self.channel, (discord.TextChannel, int)):
+            raise ValueError(f"[dpy_logger] channel {self.channel!r} is not a text channel")
 
     async def _get_guild(self, guild):
         """resolve a guild from id-or-object, raising if unresolvable"""
@@ -139,7 +157,14 @@ class DPYLogger:
             if isinstance(self.channel, discord.TextChannel):
                 return self.channel
             if isinstance(self.channel, int):
-                channel = await guild.fetch_channel(self.channel)
+                # fetch_channel raises NotFound/Forbidden/HTTPException/InvalidData (a
+                # ClientException, not an HTTPException); normalize all of those to the
+                # lib's ValueError so a bad construction channel id fails loud with one
+                # error type, matching the settings path below
+                try:
+                    channel = await guild.fetch_channel(self.channel)
+                except (discord.HTTPException, discord.ClientException) as error:
+                    raise ValueError(f"[dpy_logger] could not fetch channel {self.channel}: {error}") from error
                 if not isinstance(channel, discord.TextChannel):
                     # fetch_channel can return a Voice/Category/Forum channel; fail loud
                     # at setup like the settings path, not later via an AttributeError on .send
@@ -152,8 +177,9 @@ class DPYLogger:
             raise ValueError(f"[dpy_logger] no log channel configured for guild {guild.id}")
         try:
             channel = await guild.fetch_channel(channel_id)
-        except discord.HTTPException as error:
+        except (discord.HTTPException, discord.ClientException) as error:
-            # fetch_channel raises NotFound/Forbidden/HTTPException; normalize to the
+            # fetch_channel raises NotFound/Forbidden/HTTPException/InvalidData (a
+            # ClientException, not an HTTPException); normalize all of those to the
             # lib's ValueError so a bad configured id fails loud with one error type
             raise ValueError(f"[dpy_logger] could not fetch channel {channel_id}: {error}") from error
         if not isinstance(channel, discord.TextChannel):
@@ -171,14 +197,16 @@ class DPYLogger:
         if self._embed_builder is not None:
             return self._embed_builder(self, level, action, actor, details)
         em = discord.Embed(color=self.colors[level])
-        if action:
+        # test `is not None` so a falsy-but-valid value (0, False) still renders; only a
+        # genuinely absent field (None) or an empty string is dropped/substituted below
+        if action is not None and str(action) != "":
             em.add_field(name="Action", value=f"`{action}`", inline=True)
-        if actor:
+        if actor is not None and str(actor) != "":
             em.add_field(name="Actor", value=f"`{actor}`", inline=True)
         # discord rejects an empty field value (50035) and truncates nothing itself, so
         # an empty or >1024-char message would 400 the send; substitute + cap to keep
         # every logging call producing a valid embed
-        log_value = str(details) if details else "(no message)"
+        log_value = str(details) if details is not None and str(details) != "" else "(no message)"
         if len(log_value) > 1024:
             log_value = log_value[:1021] + "..."
         em.add_field(name="Log", value=log_value, inline=False)
@@ -192,20 +220,28 @@ class DPYLogger:
 
     def _emit_stdlib(self, level, action, actor, log_msg):
         """mirror the log line to the stdlib logger (routed to file/console by the app)"""
-        parts = [p for p in (action, str(actor) if actor else None, log_msg) if p]
+        # render falsy-but-valid parts (0, False); drop only genuinely-absent (None) ones
+        raw = (action, str(actor) if actor is not None else None, log_msg)
+        parts = [str(p) for p in raw if p is not None and str(p) != ""]
         _log.log(LEVEL_MAP.get(level, logging.INFO), f"[{level}] " + " | ".join(parts))
 
-    async def _send(self, level, log_msg, action=None, actor=None, guild=None, log_to_file=None):
+    async def _send(self, level, log_msg, action=None, actor=None, guild=None,
+                    log_to_file=None, content=None):
         """resolve channel and dispatch a leveled embed; mirror to stdlib unless opted out
 
         stdlib emit happens first so the record survives even if the discord send fails.
         a failed send falls back to stdlib rather than propagating into the caller.
+        `content` carries the critical-level ping/@here text (None for the other levels),
+        so every level shares this one send/error contract.
         """
         if self.log_to_file if log_to_file is None else log_to_file:
             self._emit_stdlib(level, action, actor, log_msg)
         try:
             channel = await self._resolve(guild)
-            return await channel.send(embed=self.build_embed(level, action, actor, log_msg))
+            return await channel.send(
+                content=content,
+                embed=self.build_embed(level, action, actor, log_msg),
+            )
         except Exception:
             _log.exception(f"[dpy_logger] failed to send {level} log: {log_msg}")
             return None
@@ -237,21 +273,15 @@ class DPYLogger:
         return await self._send("task", log, action, "SYSTEM/TASK", guild, log_to_file)
 
     async def critical(self, log, action=None, actor=None, guild=None, log_to_file=None):
-        """log a critical-level message and ping configured devs"""
+        """log a critical-level message and ping configured devs
-        if self.log_to_file if log_to_file is None else log_to_file:
+
-            self._emit_stdlib("critical", action, actor, log)
+        delegates to _send with the ping/@here content so the send + error contract has a
+        single source of truth; critical only adds the alert `content`.
+        """
         if self.pings:
             content = "alert: " + " ".join(f"<@{u}>" for u in self.pings)
         elif self.alert_here:
             content = "alert: @here"
         else:
             content = None
-        try:
+        return await self._send("critical", log, action, actor, guild, log_to_file, content)
-            channel = await self._resolve(guild)
-            return await channel.send(
-                content=content,
-                embed=self.build_embed("critical", action, actor, log),
-            )
-        except Exception:
-            _log.exception(f"[dpy_logger] failed to send critical log: {log}")
-            return None