Compare commits
4
Commits
9b6cf3bd05
..
v0.1.0
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f480a7c077 | ||
|
|
dd56009add | ||
|
|
988464ef12 | ||
|
|
7a5684e065 |
@@ -70,10 +70,13 @@ await bot.log.debug("noisy", log_to_file=False) # -> Discord only
|
|||||||
|
|
||||||
## Errors
|
## Errors
|
||||||
|
|
||||||
Resolution failures (unresolvable guild/channel, bad config) raise `ValueError` at
|
Resolution failures (unresolvable guild/channel, bad config) raise from `initialize()`
|
||||||
`initialize`/call time — a misconfigured logger should fail loudly at setup. Per-call
|
— a misconfigured logger should fail loudly at setup. The raised type is usually
|
||||||
**send** failures do **not** propagate: they fall back to the stdlib logger so a
|
`ValueError`, but an underlying `discord` exception (`NotFound` / `Forbidden` /
|
||||||
transient Discord failure never breaks the caller's command.
|
`HTTPException`) from `fetch_guild`/`fetch_channel` can also propagate. On a **per-call**
|
||||||
|
send, neither resolution nor send failures propagate: they fall back to the stdlib
|
||||||
|
logger so a transient Discord failure (or a per-call `guild=` that doesn't resolve)
|
||||||
|
never breaks the caller's command.
|
||||||
|
|
||||||
## Construction contract
|
## Construction contract
|
||||||
|
|
||||||
|
|||||||
@@ -41,9 +41,10 @@ extending: this base has no feed/announcement method by design. a project
|
|||||||
that wants one subclasses DPYLogger and adds it, reusing _resolve.
|
that wants one subclasses DPYLogger and adds it, reusing _resolve.
|
||||||
|
|
||||||
errors: resolution failures (unresolvable guild/channel, bad config) raise
|
errors: resolution failures (unresolvable guild/channel, bad config) raise
|
||||||
ValueError at initialize/call time — a misconfigured logger should fail loudly.
|
ValueError from `initialize()` — a misconfigured logger should fail loudly at
|
||||||
per-call send failures do NOT propagate: they fall back to the stdlib logger so
|
setup. on a per-call send, resolution AND send failures do NOT propagate: they
|
||||||
a transient discord failure never breaks the caller's command.
|
fall back to the stdlib logger so a transient discord failure (or a per-call
|
||||||
|
`guild=` that doesn't resolve) never breaks the caller's command.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
import logging
|
import logging
|
||||||
@@ -128,7 +129,7 @@ class DPYLogger:
|
|||||||
if not guild:
|
if not guild:
|
||||||
raise ValueError("[dpy_logger] cannot resolve channel without a guild")
|
raise ValueError("[dpy_logger] cannot resolve channel without a guild")
|
||||||
|
|
||||||
if not override and guild == self.guild:
|
if not override and getattr(guild, "id", guild) == getattr(self.guild, "id", self.guild):
|
||||||
if isinstance(self.channel, discord.TextChannel):
|
if isinstance(self.channel, discord.TextChannel):
|
||||||
return self.channel
|
return self.channel
|
||||||
if isinstance(self.channel, int):
|
if isinstance(self.channel, int):
|
||||||
|
|||||||
Reference in New Issue
Block a user