rethink-public/dpy_appemojis
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: rethink-public/dpy_appemojis:v1.0.0
Branches Tags
rethink-public/dpy_appemojis:main
rethink-public/dpy_appemojis:v1.1.0 rethink-public/dpy_appemojis:v1.0.0
...
compare: rethink-public/dpy_appemojis:7adb8dc38632590ebfda56f56883400a78d3f8e5
Branches Tags
rethink-public/dpy_appemojis:main
rethink-public/dpy_appemojis:v1.1.0 rethink-public/dpy_appemojis:v1.0.0
2 Commits
v1.0.0 ... 7adb8dc386
Author SHA1 Message Date
dsql 7adb8dc386 chore: bump to 1.1.0 (logging-discipline audit) 
Signed-off-by: disqualifier <dev@disqualifier.me>
 2026-08-10 23:00:50 -04:00
dsql d2bfb949ee fix: drop log-and-raise in create/delete emoji error paths 
both HTTPException handlers logged at ERROR then re-raised - raise XOR log. the exception
propagates unwrapped to the caller (the documented fail-loud contract), so it already
carries the failure; the error log double-reported it. drop the log, keep the raise. the
module logger stays defined (emit-only) for future use.

Signed-off-by: disqualifier <dev@disqualifier.me>
 2026-08-09 02:12:08 -04:00
2 changed files with 4 additions and 3 deletions
Expand all files Collapse all files
pyproject.toml
+1 -1
View File
@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
[project] [project]
name = "dpy_appemojis" name = "dpy_appemojis"
version = "1.0.0" version = "1.1.0"
description = "Mirror a project folder onto the bot's application emojis for discord.py — folder is the source of truth. Config-free, injectable, installable." description = "Mirror a project folder onto the bot's application emojis for discord.py — folder is the source of truth. Config-free, injectable, installable."
requires-python = ">=3.10" requires-python = ">=3.10"
dependencies = [ dependencies = [
src/dpy_appemojis/dpy_appemojis.py
+3 -2
View File
@@ -175,7 +175,8 @@ class DPYAppEmojis:
try: try:
emoji = await self._client.create_application_emoji(name=name, image=image) emoji = await self._client.create_application_emoji(name=name, image=image)
except discord.HTTPException: except discord.HTTPException:
log.error("dpy_appemojis: creating application emoji '%s' failed", name) # raise XOR log: this re-raises, so the exception carries the failure to the
# caller (who decides fatal-vs-routine) - no error log here would double-report.
raise raise
current[name] = emoji current[name] = emoji
result.created.append(name) result.created.append(name)
@@ -185,7 +186,7 @@ class DPYAppEmojis:
try: try:
await emoji.delete() await emoji.delete()
except discord.HTTPException: except discord.HTTPException:
log.error("dpy_appemojis: deleting application emoji '%s' failed", name) # raise XOR log: re-raises, so the exception is the signal - no log here.
raise raise
current.pop(name, None) current.pop(name, None)
result.deleted.append(name) result.deleted.append(name)