fix: drop log-and-raise in create/delete emoji error paths

both HTTPException handlers logged at ERROR then re-raised - raise XOR log. the exception
propagates unwrapped to the caller (the documented fail-loud contract), so it already
carries the failure; the error log double-reported it. drop the log, keep the raise. the
module logger stays defined (emit-only) for future use.

Signed-off-by: disqualifier <dev@disqualifier.me>
This commit is contained in:
2026-08-09 02:12:08 -04:00
parent 818579215b
commit d2bfb949ee
+3 -2
View File
@@ -175,7 +175,8 @@ class DPYAppEmojis:
try:
emoji = await self._client.create_application_emoji(name=name, image=image)
except discord.HTTPException:
log.error("dpy_appemojis: creating application emoji '%s' failed", name)
# raise XOR log: this re-raises, so the exception carries the failure to the
# caller (who decides fatal-vs-routine) - no error log here would double-report.
raise
current[name] = emoji
result.created.append(name)
@@ -185,7 +186,7 @@ class DPYAppEmojis:
try:
await emoji.delete()
except discord.HTTPException:
log.error("dpy_appemojis: deleting application emoji '%s' failed", name)
# raise XOR log: re-raises, so the exception is the signal - no log here.
raise
current.pop(name, None)
result.deleted.append(name)