fix: drop log-and-raise in create/delete emoji error paths
both HTTPException handlers logged at ERROR then re-raised - raise XOR log. the exception propagates unwrapped to the caller (the documented fail-loud contract), so it already carries the failure; the error log double-reported it. drop the log, keep the raise. the module logger stays defined (emit-only) for future use. Signed-off-by: disqualifier <dev@disqualifier.me>
This commit is contained in:
@@ -175,7 +175,8 @@ class DPYAppEmojis:
|
|||||||
try:
|
try:
|
||||||
emoji = await self._client.create_application_emoji(name=name, image=image)
|
emoji = await self._client.create_application_emoji(name=name, image=image)
|
||||||
except discord.HTTPException:
|
except discord.HTTPException:
|
||||||
log.error("dpy_appemojis: creating application emoji '%s' failed", name)
|
# raise XOR log: this re-raises, so the exception carries the failure to the
|
||||||
|
# caller (who decides fatal-vs-routine) - no error log here would double-report.
|
||||||
raise
|
raise
|
||||||
current[name] = emoji
|
current[name] = emoji
|
||||||
result.created.append(name)
|
result.created.append(name)
|
||||||
@@ -185,7 +186,7 @@ class DPYAppEmojis:
|
|||||||
try:
|
try:
|
||||||
await emoji.delete()
|
await emoji.delete()
|
||||||
except discord.HTTPException:
|
except discord.HTTPException:
|
||||||
log.error("dpy_appemojis: deleting application emoji '%s' failed", name)
|
# raise XOR log: re-raises, so the exception is the signal - no log here.
|
||||||
raise
|
raise
|
||||||
current.pop(name, None)
|
current.pop(name, None)
|
||||||
result.deleted.append(name)
|
result.deleted.append(name)
|
||||||
|
|||||||
Reference in New Issue
Block a user